Merge pull request #229 from Man-Jain/issue-228

Fix test case for delegate call test_ExecuteDelegateCallFromExecutor_Success
bcnmy · Dec 19, 2024 · be790e8 · be790e8
2 parents 036e348 + fb07c7e
commit be790e8
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/test/foundry/unit/concrete/accountexecution/TestAccountExecution_ExecuteFromExecutor.t.sol b/test/foundry/unit/concrete/accountexecution/TestAccountExecution_ExecuteFromExecutor.t.sol
@@ -61,11 +61,13 @@ contract TestAccountExecution_ExecuteFromExecutor is TestAccountExecution_Base {
 
         address valueTarget = makeAddr("valueTarget");
         uint256 value = 1 ether;
-        bytes memory sendValueCallData =
-            abi.encodeWithSelector(MockDelegateTarget.sendValue.selector, valueTarget, value);
+        bytes memory sendValueCallData = abi.encodePacked(
+            address(delegateTarget),
+            abi.encodeWithSelector(MockDelegateTarget.sendValue.selector, valueTarget, value)
+        );
         mockExecutor.execDelegatecall(BOB_ACCOUNT, sendValueCallData);
         // Assert that the value was set ie that execution was successful
-        // assertTrue(valueTarget.balance == value);
+        assertTrue(valueTarget.balance == value);
     }
 
     /// @notice Tests batch execution via MockExecutor