Sig malleability protection for erc1271 only

[filmakarov]

Moved sig malleability protection to 1271 flow only as for erc4337 it is excess

1. ERC-4337 flow has nonce protection against replays including signature malleability. So there is no need to apply this check

2. ERC-1271 flow has no in-built protection against replays including signature malleability.
   Even reference implementation includes the 's' check: https://eips.ethereum.org/EIPS/eip-1271#reference-implementation

If one is using OZ's ECDSA, this above check is applied under the hood : https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/utils/cryptography/ECDSA.sol#L134-L145
However, in our K1Validator we use Solady ECDSA.tryRecover

nexus/contracts/modules/validators/K1Validator.sol

Line 15 in 69f437b

import { ECDSA } from "solady/utils/ECDSA.sol";

https://github.com/Vectorized/solady/blob/45bba1221ad451289d2f54c2f7f48aea624e17aa/src/utils/ECDSA.sol#L218-L259
which, as far I can see, doesn't have such a check

Of course disallowing using n - s is not considered to be the full replay protection. However, we can not know if any additional protection is incorporated into the signed hash in 1271, at the same time we can not enforce stronger replay protection such as nonce, so we can at least protect from signature malleability and expect protocols which use 1271 to have their own replay protection (and if they decide to use full bytes signature as protection, they are covered from malleability).

[openzeppelin-code]

Sig malleability protection for erc1271 only

Generated at commit: bbe68ea106c4729019703e05aa7fc99fb7a546e8

🚨 Report Summary

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	1 1 0 6 27 35

---

For more details view the full report in OpenZeppelin Code Inspector

[codecov]

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.68%. Comparing base (0351f93) to head (bbe68ea).
Report is 6 commits behind head on dev.

Files with missing lines	Patch %	Lines
contracts/modules/validators/K1Validator.sol	25.00%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #215      +/-   ##
==========================================
- Coverage   85.00%   84.68%   -0.32%     
==========================================
  Files          13       13              
  Lines         847      849       +2     
  Branches      249      271      +22     
==========================================
- Hits          720      719       -1     
- Misses        112      115       +3     
  Partials       15       15              

Files with missing lines	Coverage Δ
contracts/modules/validators/K1Validator.sol	68.67% <25.00%> (-2.94%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69f437b...bbe68ea. Read the comment docs.

[livingrockrises]

got it. lgtm

[livingrockrises]

codecov/patch check is failing.

[github-actions]

Changes to gas cost

Generated at commit: 8058ccb31a6870a8c60f2aca104c56b0fbf84c8f, compared to commit: 69f437bb5db46e60c62bb780fcebc4120cab130a

🧾 Summary (5% most significant diffs)

Contract	Method	Avg (+/-)	%

---

Full diff report 👇

Contract	Deployment Cost (+/-)	Method	Min (+/-)	%	Avg (+/-)	%	Median (+/-)	%	Max (+/-)	%	# Calls (+/-)
MockPaymaster	1,063,705 (+187)
HelperConfig	7,039,537 (+3,204,972)

[github-actions]

🤖 Slither Analysis Report 🔎

Slither report

# Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary
🟡 - locked-ether (1 results) (Medium)

• constable-states (2 results) (Optimization)

locked-ether

🟡 Impact: Medium
🔴 Confidence: High

• ID-0
  Contract locking ether found:
  Contract NexusBootstrap has payable functions:
  • ModuleManager.receive()
  • ModuleManager.fallback(bytes)
    But does not have a function to withdraw the ether

utils/NexusBootstrap.sol#L33-L165

constable-states

Impact: Optimization
🔴 Confidence: High

• ID-1
  RegistryAdapter.registry should be constant

base/RegistryAdapter.sol#L10

• ID-2
  RegistryFactory.threshold should be constant

factory/RegistryFactory.sol#L39

_This comment was automatically generated by the GitHub Actions workflow._

[filmakarov]

codecov/patch check is failing.

fuck it. It shows 'uncovered' for lines which in fact are.