Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remediations re 7739 update #216

Merged
merged 6 commits into from
Nov 11, 2024

fix

0fd6769
Select commit
Loading
Failed to load commit list.
Merged

Remediations re 7739 update #216

fix
0fd6769
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 11, 2024 in 0s

84.45% (target 80.00%)

View this Pull Request on Codecov

84.45% (target 80.00%)

Details

Codecov Report

Attention: Patch coverage is 46.15385% with 7 lines in your changes missing coverage. Please review.

Project coverage is 84.45%. Comparing base (bbe68ea) to head (0fd6769).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
contracts/Nexus.sol 46.15% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #216      +/-   ##
==========================================
- Coverage   84.68%   84.45%   -0.24%     
==========================================
  Files          13       13              
  Lines         849      849              
  Branches      271      249      -22     
==========================================
- Hits          719      717       -2     
- Misses        115      117       +2     
  Partials       15       15              
Files with missing lines Coverage Δ
contracts/modules/validators/K1Validator.sol 70.12% <ø> (+1.45%) ⬆️
contracts/Nexus.sol 82.41% <46.15%> (-2.25%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d015436...0fd6769. Read the comment docs.