Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/7739 report #218

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Add/7739 report #218

merged 1 commit into from
Nov 21, 2024

Conversation

filmakarov
Copy link
Collaborator

No description provided.

@filmakarov filmakarov changed the base branch from main to dev November 21, 2024 11:23
Copy link

Changes to gas cost

Generated at commit: e1b94a190b359423bc18db0a55b02af2e489053a, compared to commit: fd4db096db1e9e73329966e5ca9f57967e13be09

🧾 Summary (5% most significant diffs)

Contract Method Avg (+/-) %
Nexus validateUserOp +6 ❌ +0.04%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
Nexus 4,762,675 (+37,085) validateUserOp 13,865 (+6) +0.04% 15,436 (+6) +0.04% 13,865 (+6) +0.04% 42,634 (+6) +0.01% 347 (0)
MockValidator 990,635 (+22,622)
HelperConfig 3,834,565 (+52,700)

Copy link

🤖 Slither Analysis Report 🔎

Slither report

# Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary
🟡 - locked-ether (1 results) (Medium)

locked-ether

🟡 Impact: Medium
🔴 Confidence: High

utils/NexusBootstrap.sol#L33-L165

constable-states

Impact: Optimization
🔴 Confidence: High

base/RegistryAdapter.sol#L10

factory/RegistryFactory.sol#L39

_This comment was automatically generated by the GitHub Actions workflow._

Copy link

Add/7739 report

Generated at commit: 8f0458d3117f1ea97b7320a02a63cd5e61cdd0b4

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
1
1
0
6
27
35

For more details view the full report in OpenZeppelin Code Inspector

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.45%. Comparing base (aca6343) to head (8f0458d).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #218   +/-   ##
=======================================
  Coverage   84.45%   84.45%           
=======================================
  Files          13       13           
  Lines         849      849           
  Branches      271      271           
=======================================
  Hits          717      717           
  Misses        117      117           
  Partials       15       15           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28dbede...8f0458d. Read the comment docs.

---- 🚨 Try these New Features:

@filmakarov filmakarov merged commit 93241d2 into dev Nov 21, 2024
8 of 10 checks passed
@filmakarov filmakarov deleted the add/7739-report branch November 21, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants