Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to last audited commit (9f1c23f6) #224

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

filmakarov
Copy link
Collaborator

As per communication with Spearbit it was decided to remove the check

  1. Nor me neither auditors were able to figure out the PoC to exploit this
  2. Solady doesn't have this check in their lib: link
  3. The check was inaccurate anyways (executions.length returns struct array length, not bytes array length)

@filmakarov filmakarov merged commit 90b2d5a into dev Dec 9, 2024
4 of 5 checks passed
@filmakarov filmakarov deleted the release/prepare-revert-check branch December 9, 2024 07:33
Copy link

Revert to last audited commit (9f1c23f6)

Generated at commit: 1a636426fb9d14da4faa515fcbf4c58868662ffc

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
1
1
0
6
27
35

For more details view the full report in OpenZeppelin Code Inspector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant