Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency of tests on scripts #230

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Remove dependency of tests on scripts #230

merged 1 commit into from
Dec 18, 2024

Conversation

filmakarov
Copy link
Collaborator

@filmakarov filmakarov commented Dec 18, 2024

Fix this #223


PR-Codex overview

This PR focuses on refactoring the TestHelper contract to streamline the setup of the ENTRYPOINT address, replacing the instantiation of HelperConfig with a new setupEntrypoint function that handles both test and mainnet scenarios.

Detailed summary

  • Removed the import of HelperConfig in TestHelper.
  • Added a setupEntrypoint function in TestHelper to initialize ENTRYPOINT.
  • The setupEntrypoint function checks the chainid and sets ENTRYPOINT accordingly.
  • The constant MAINNET_ENTRYPOINT_ADDRESS is defined in both HelperConfig and TestHelper.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@filmakarov filmakarov merged commit 3fc0861 into dev Dec 18, 2024
5 checks passed
@filmakarov filmakarov deleted the fix/scripts-dep branch December 18, 2024 13:09
Copy link

🤖 Slither Analysis Report 🔎

Slither report

# Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary
🟡 - locked-ether (1 results) (Medium)

locked-ether

🟡 Impact: Medium
🔴 Confidence: High

utils/NexusBootstrap.sol#L33-L165

constable-states

Impact: Optimization
🔴 Confidence: High

base/RegistryAdapter.sol#L10

factory/RegistryFactory.sol#L39

_This comment was automatically generated by the GitHub Actions workflow._

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant