Feat/clean refactor #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Aboudjem
commented
May 22, 2024
•
Aboudjem
commented
- Added units tests we have 100% coverage on BaseAccount, ExecutionHelper, ModuleManager and Storage (% Lines, % Statements, % Branches, % Funcs)
- Added new tests for Fallback
- Fixed bug on _TryExecute not emitting the proper return and index
- Fixed bug on FallBackHandler Installation reverting if you pass any CallType (it was working before because we were passing nothing and by default is 0 which corresponds to CALLTYPE_SINGLE
- Added a few test cases to cover more edge cases
- Update place where solidity was 0.8.23 to 0.8.24
…ate Solidity version to 0.8.24
check on this one has failed |
|
three other CI flows fail |
…loyed Nexus account and Paymaster
…ployed Nexus account and Paymaster
… an already deployed Nexus smart account using a paymaster
…-and-push-gas-report scripts
… an already deployed Nexus smart account using a paymaster
…m an already deployed Nexus smart account using a paymaster
…dy deployed Nexus smart account using a paymaster
…m an already deployed Nexus smart account using a paymaster
…-and-push-gas-report scripts
…dy deployed Nexus smart account using a paymaster
…rom an already deployed Nexus smart account using a paymaster
…ad of staticFunction and singleFunction
…improve code readability
🤖 Slither Analysis Report 🔎Slither report
# Slither report
_This comment was automatically generated by the GitHub Actions workflow._
THIS CHECKLIST IS NOT COMPLETE. Use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.