fix: exclude CJS-MJS coverages from results

fix #14
bcoe · Apr 28, 2019 · ab23cb1 · ab23cb1
1 parent 51a9fa7
commit ab23cb1
Show file tree

Hide file tree

Showing 7 changed files with 379 additions and 10 deletions.
diff --git a/lib/report.js b/lib/report.js
@@ -62,8 +62,19 @@ class Report {
       try {
         const path = resolve(this.resolve, v8ScriptCov.url)
         const script = v8toIstanbul(path, this.wrapperLength)
-        script.applyCoverage(v8ScriptCov.functions)
-        map.merge(script.toIstanbul())
+
+        if (v8ScriptCov.functions.every(({ ranges }) => {
+          for (const { endOffset } of ranges) {
+            if (endOffset > script.source.length) {
+              return false
+            }
+          }
+
+          return true
+        })) {
+          script.applyCoverage(v8ScriptCov.functions)
+          map.merge(script.toIstanbul())
+        }
       } catch (err) {
         console.warn(`file: ${v8ScriptCov.url} error: ${err.stack}`)
       }

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -42,7 +42,7 @@
     "rimraf": "^2.6.2",
     "test-exclude": "^5.0.0",
     "uuid": "^3.3.2",
-    "v8-to-istanbul": "^2.0.4",
+    "v8-to-istanbul": "^2.1.0",
     "yargs": "^13.1.0",
     "yargs-parser": "^10.1.0"
   },

diff --git a/test/fixtures/export.js b/test/fixtures/export.js
@@ -0,0 +1,354 @@
+module.exports = function foo() {
+  /* This file contains a lot of lines to test if `endOffset` of the CJS-ESM bridge is always larger than the EOF position.
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+  */
+  return 'foo'
+}