-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: additional tests for relative path support #490
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcknasty
force-pushed
the
directory-unit-tests
branch
from
July 30, 2023 17:20
933c9df
to
5ed96e5
Compare
test: relative directories for tmpDir and reportsDir test: absolute directories for tmpDir and reportsDir
mcknasty
force-pushed
the
directory-unit-tests
branch
from
January 5, 2024 12:49
5ed96e5
to
3c12e97
Compare
bcoe
reviewed
Jan 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this increase coverage should we land it?
@bcoe They look about the same. There is a small rounding difference but the uncovered lines are the same. Additional tests don't hurt though, especially when it comes to Test Driven Development.
|
bcoe
changed the title
Artifact Directory Unit Tests
test: additional tests for relative path support
Jan 15, 2024
bcoe
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request 490
Artifact Directory Unit Tests
test: relative directories for tmpDir and reportsDir
test: absolute directories for tmpDir and reportsDir
Following the Contributions Recommendations here.
Unit Tests Results
Node Version Testing Matrix
*Node version 10.x support has been deprecated.