Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #495 is marked as closed, but the solution provided in the comment is not working for me. Post node 20 (including node v21) I can't get the node process to stop gracefully.
This issue is fixed in the latest versions of
foreground-child
, and bumping it solves all the issues we had.A note about the tests. Running the tests against the main branch results in the tests failing (tested against node v20.5.0 and v21.2.0):
These failures are the same I'm getting after the changes to this PR.
Happy to look into fixing these two test, but would like to some guidance from the maintainers.
Checklist
npm test
, tests passingnpm run test:snap
(to update the snapshot)