Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update foreground-child version #503

Conversation

adalbertoteixeira
Copy link

Issue #495 is marked as closed, but the solution provided in the comment is not working for me. Post node 20 (including node v21) I can't get the node process to stop gracefully.

This issue is fixed in the latest versions of foreground-child, and bumping it solves all the issues we had.

A note about the tests. Running the tests against the main branch results in the tests failing (tested against node v20.5.0 and v21.2.0):

  1) c8
       allows relative files to be included:
     AssertionError: expected ',first\n\nsecond\n\n-----------------…' to match /Error: ENOENT: no such file or directory.*loaders\.js/
      at Context.<anonymous> (test/integration.js:84:38)
      at process.processImmediate (node:internal/timers:478:21)

  2) c8 mergeAsync
       allows relative files to be included:
     AssertionError: expected ',first\n\nsecond\n\n-----------------…' to match /Error: ENOENT: no such file or directory.*loaders\.js/
      at Context.<anonymous> (test/integration.js:84:38)
      at process.processImmediate (node:internal/timers:478:21)

These failures are the same I'm getting after the changes to this PR.

Happy to look into fixing these two test, but would like to some guidance from the maintainers.

Checklist
  • [] npm test, tests passing
  • npm run test:snap (to update the snapshot)

Also update usage of process exit.
@bcoe
Copy link
Owner

bcoe commented Jan 3, 2024

Landed a slightly tweaked version of this update, thanks for the work:

#512

@bcoe bcoe closed this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants