-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing locale strings to FR locale #222
Conversation
Looks perfect 🚀 |
Thanks @LoicMahieu! I agree there are some inconsistencies in the text that yargs outputs. Not only the treatment of "JSON" vs "json" (which should probably be upper-case, as you suggest), but also a couple error messages do not start with a capital letter. I'll see what I can do to clean this up. Thanks again! |
With commit 57af0ab, I made the following changes to address the inconsistencies in current locale strings:
All tests so far look good. I will make sure the necessary changes are propagated to PR #224 for the Portuguese translation as well. |
@bcoe My last change will "break" user code that attempts to customize the following 2 error message keys via
"Break" meaning their code will no longer override the default messages, since the y18n keys have changed. It seems we would either:
What is your preference? |
@nexdrew given how new this feature is, I think I'm comfortable making this a
Now that we have translations in for French and Spanish, feel free to cut a release 👍 Let's hold off on releasing Portuguese, @seldo would like to announce this translation as part of his talk at Brazil JS. In other exciting news @sindresorhus is looking into creating a sync version of os-locale, so that we can automatically detect people's locale 💃 |
@bcoe Sounds good. I'll merge this as is and cut a |
…locale() and updateStrings() together
Add missing locale strings to FR locale
|
Ran a bunch of tests without problem. |
@nexdrew \o/ |
🇫🇷 Some strings were found to be previously missing from y18n lookup; this adds them to
fr.json
with an attempted French translation:See related discussion in PRs #220 and #221.
@LoicMahieu If you have time, I would greatly appreciate a quick review of these French translations. Thanks!