Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bslint parser config #1180

Closed
wants to merge 2 commits into from
Closed

chore: bslint parser config #1180

wants to merge 2 commits into from

Conversation

MashyBasker
Copy link

Overview

Update the .eslintrc.json to support bslint in the CI

Signed-off-by: Maharshi Basu <basumaharshi10@gmail.com>
Signed-off-by: Maharshi Basu <basumaharshi10@gmail.com>
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0c18028) 70.41% compared to head (6a5573a) 70.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1180   +/-   ##
=======================================
  Coverage   70.41%   70.41%           
=======================================
  Files         174      174           
  Lines       27515    27515           
=======================================
  Hits        19376    19376           
  Misses       8139     8139           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MashyBasker MashyBasker changed the title chore: Bslint parser config chore: bslint parser config Feb 12, 2024
@theanmolsharma
Copy link
Collaborator

Could you please explain why you made this change? bslint is already working in CI.

@MashyBasker
Copy link
Author

The original .eslintrc.json used babel-eslint as the lint parser which caused failure when running lints locally since it was deprecated. Since bslint does not need to be defined in the config file to be used, I made the change to stop using it as the parser and updated the config similar to that of bcrypto

@MashyBasker MashyBasker closed this by deleting the head repository May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants