Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bcurl: use 127.0.0.1 by default. #20

Merged
merged 1 commit into from
May 14, 2022
Merged

bcurl: use 127.0.0.1 by default. #20

merged 1 commit into from
May 14, 2022

Conversation

nodech
Copy link
Member

@nodech nodech commented May 11, 2022

Issue handshake-org/hsd#722.

We could instead overwrite the options in hs-client and don't touch bcurl. But this seemed cleaner.

@pinheadmz
Copy link
Member

yeah bcoin will need this as well

@pinheadmz
Copy link
Member

also here:

bcurl/test/http-test.js

Line 166 in d7e088f

reqHeaderDeepEqual('host', `localhost:${port}`),

We don't have CI in this repo but the test fails

@nodech nodech merged commit c6bd7c1 into bcoin-org:master May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nodech @pinheadmz