socket: don't queue events on destroyed sockets. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodech
added a commit
to nodech/hsd
that referenced
this pull request
Oct 31, 2023
If the client closes before the socket.call, next call would never resolve nor reject and locker would never unlock.
nodech
added a commit
to nodech/hsd
that referenced
this pull request
Dec 13, 2023
If the client closes before the socket.call, next call would never resolve nor reject and locker would never unlock.
nodech
added a commit
to nodech/hsd
that referenced
this pull request
Dec 13, 2023
If the client closes before the socket.call, next call would never resolve nor reject and locker would never unlock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sockets queue in the job queue when we want to wait for the response. This applies both to the closed socket (not destryoed) - which may reconnect and open connection. For both of these there's an interval running to check for timeouts for these jobs.
Situation is different when the socket destroyed. Destroyed socket may never reconnect nor should be reused. Timeout loop is also closed, so it should never queue the events but instead throw errors.