-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exit when stdin closes #23
Conversation
This is useful for long running processes that are started by other tools like web frameworks. These two lines were taken from the [postcss-cli](https://github.com/postcss/postcss-cli/blob/4be419d4dab07b8982b4bdc04456c02880dbf667/index.js#L55..L56).
My apologies, I totally missed this. Can you explain the problem thats going that this solves? |
No worries. To quote someone smarter than me.
Basically, when I start cpx as a "watcher" with Elixir/Erlang, there is a zombie node process of cpx that persists after the Elixir/Erlang VM exits. |
Cool, sounds good. I'll run some tests locally to make sure everything is still working as expected. |
Seems to work fine here. I'll do a release. |
cpx2@3.0.1 |
This change somehow breaks my usage with lerna. You can take this project as a reproduction: https://github.com/vuepress/vuepress-next/blob/main/package.json yarn
yarn copy-watch The |
@meteorlxy Sorry about that. Pin to 3.0.0 while we figure this out. @mhanberg any ideas? |
I'm going to revert the change until we can clarify the issue being solved here more. @mhanberg can you send me a small gist or something with a package.json and whatever scripts you were using that sets up the zombie process issue you ran into? |
This reverts commit ae1f9b7, reversing changes made to 7fb869b. See #23 (comment) # Conflicts: # bin/main.js
Reverted: cpx2@3.0.2 |
This is useful for long running processes that are started by other tools like web frameworks.
These two lines were taken from the postcss-cli.