Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use neostandard + add more static code analysis #142

Merged
merged 5 commits into from
Jul 2, 2024
Merged

Conversation

voxpelli
Copy link
Collaborator

@voxpelli voxpelli commented Jul 2, 2024

This replaces standard with neostandard and:

  • adds the result of running a npx eslint --fix
  • removes no longer supported /* eslint-env mocha */ and replaces it with env: ['mocha'] in the neostandard config (it adds it globally, but I think that's okay for this project, a more deluxe solution would be to instead do: https://github.com/voxpelli/eslint-config/blob/main/base-configs/mocha.js)
  • adds a neostandard badge, I opted for the one without the neostandard colors 😜

Also:

  • adds rimraf, because there's a dependency on it that worked when standard made it be included
  • adds knip to help avoid the above
  • cleaned up stuff and refactored some stuff to help knip
  • added installed-check to ensure that the engine range is good

@voxpelli voxpelli requested a review from bcomnes July 2, 2024 13:31
@voxpelli voxpelli self-assigned this Jul 2, 2024
Copy link

socket-security bot commented Jul 2, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/eslint@9.6.0 environment Transitive: eval, filesystem, unsafe +82 9.81 MB eslintbot
npm/installed-check@9.3.0 Transitive: environment, filesystem, shell +66 4.66 MB voxpelli
npm/knip@5.23.3 environment Transitive: filesystem, shell, unsafe +82 30.9 MB webpro
npm/neostandard@0.11.0 Transitive: environment, filesystem, unsafe +75 33.2 MB voxpelli
npm/rimraf@5.0.7 environment, filesystem Transitive: shell +23 3.2 MB isaacs

View full report↗︎

@voxpelli voxpelli changed the title Use neostandard Use neostandard + add more static code analysis Jul 2, 2024
@bcomnes
Copy link
Owner

bcomnes commented Jul 2, 2024

Thanks for doing all of that. No breaking changes right?

@voxpelli
Copy link
Collaborator Author

voxpelli commented Jul 2, 2024

Only such change would be the narrowing of the engine definition to match that of the dependencies, else nothing 😌

@voxpelli
Copy link
Collaborator Author

voxpelli commented Jul 2, 2024

@bcomnes You want me to merge or you will merge? :)

@bcomnes
Copy link
Owner

bcomnes commented Jul 2, 2024

I won't have time till later so feel free.

@voxpelli voxpelli merged commit 25738ae into master Jul 2, 2024
12 checks passed
@voxpelli voxpelli deleted the use-neostandard branch July 2, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants