Switch to JS-based which command
#154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version `3.0.1` of `which` is the latest that supports Node 14. Version 4 requires Node 16 and version 5 requires Node 18. So I'm sticking with `3.0.1` to avoid bumping the engines range in this PR. `which` is built and maintained by `npm`: https://github.com/npm/node-which And is tested across multiple environments: https://github.com/npm/node-which/blob/b8d11c791296a3baf44703352619621215189b0e/.github/workflows/ci.yml#L54-L65 Fixes #153
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
jdalton
reviewed
Oct 3, 2024
| @@ -36,7 +36,8 @@ | |||
| "minimatch": "^9.0.0", | |||
| "pidtree": "^0.6.0", | |||
| "read-package-json-fast": "^3.0.2", | |||
| "shell-quote": "^1.7.3" | |||
| "shell-quote": "^1.7.3", | |||
| "which": "^3.0.1" | |||
|
Sorry for the delay, thanks for fixing this. |
bcomnes
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version
3.0.1ofwhichis the latest that supports Node 14. Version 4 requires Node 16 and version 5 requires Node 18. So I'm sticking with3.0.1to avoid bumping the engines range in this PR.whichis built and maintained bynpm: https://github.com/npm/node-whichAnd is tested across multiple environments: https://github.com/npm/node-which/blob/b8d11c791296a3baf44703352619621215189b0e/.github/workflows/ci.yml#L54-L65
Fixes #153