Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodeQL workflow #65

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Add CodeQL workflow #65

merged 1 commit into from
Oct 13, 2021

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Oct 5, 2021

There's a ReDoS issue in the upstream project; this should detect such issues.

PS. I really think it's of everyone's best interest if this fork was merged with upstream. I'll try to get in touch with mysticatea too.

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2021

Codecov Report

Merging #65 (be8969e) into master (8e72b7c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #65   +/-   ##
=======================================
  Coverage   92.66%   92.66%           
=======================================
  Files          23       23           
  Lines         477      477           
=======================================
  Hits          442      442           
  Misses         35       35           
Flag Coverage Δ
ubuntu-latest-12 92.56% <ø> (ø)
ubuntu-latest-14 92.56% <ø> (ø)
windows-latest-12 92.47% <ø> (ø)
windows-latest-14 ?

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8356ed...be8969e. Read the comment docs.

Copy link
Owner

@bcomnes bcomnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't had a chance to try out CodeQL. The upstream warnings I believe were addressed when I updated some dependencies a while ago. I'd be willing to try this out and see if it generates any useful information.

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Oct 5, 2021

This is the ReDoS upstream issue https://lgtm.com/projects/g/mysticatea/npm-run-all?mode=list

GitHub has bought semmle so CodeQL should highlight such issues.

@bcomnes bcomnes merged commit 106fff8 into bcomnes:master Oct 13, 2021
@XhmikosR XhmikosR deleted the codeql branch October 14, 2021 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants