Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move support to node 16 and npm 8 #85

Merged
merged 2 commits into from
Jun 11, 2022
Merged

Conversation

bcomnes
Copy link
Owner

@bcomnes bcomnes commented Jun 10, 2022

Fix tests for newer versions of node and npm, and also bump engines to the latest versions of node and npm. YMMV with older versions, though nothing specifically will break with this change other than a warning.

It looks like npm config overrides stopped working in npm 7. Let's just disable those tests when running in envs that doesn't support it. It will continue working if you are running npm 6, but you should stop doing that.

Closes #79
BREAKING CHANGE: Support only node >= 16 and npm >= 8. YMMV with older versions.
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2022

Codecov Report

Merging #85 (7d19dd4) into master (8e72b7c) will increase coverage by 4.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
+ Coverage   92.66%   96.75%   +4.09%     
==========================================
  Files          23       23              
  Lines         477     1973    +1496     
==========================================
+ Hits          442     1909    +1467     
- Misses         35       64      +29     
Flag Coverage Δ
macos-latest-18 96.56% <ø> (?)
ubuntu-latest-12 ?
ubuntu-latest-14 ?
ubuntu-latest-18 96.15% <ø> (?)
windows-latest-12 ?
windows-latest-14 ?
windows-latest-18 96.22% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bin/common/parse-cli-args.js 92.82% <0.00%> (-0.43%) ⬇️
lib/spawn.js 100.00% <0.00%> (ø)
bin/run-p/help.js 100.00% <0.00%> (ø)
bin/run-s/help.js 100.00% <0.00%> (ø)
bin/run-p/index.js 100.00% <0.00%> (ø)
bin/run-s/index.js 100.00% <0.00%> (ø)
lib/match-tasks.js 100.00% <0.00%> (ø)
lib/spawn-posix.js 100.00% <0.00%> (ø)
lib/spawn-win32.js 100.00% <0.00%> (ø)
bin/common/version.js 100.00% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a64a46...7d19dd4. Read the comment docs.

@bcomnes bcomnes merged commit 1b8e1c8 into master Jun 11, 2022
@bcomnes bcomnes deleted the disable-npm-config-overrides branch June 11, 2022 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants