Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for lookbehind and negative lookbehind #129

Closed
wants to merge 1 commit into from

Conversation

luiz290788
Copy link

No description provided.

@luiz290788
Copy link
Author

@bd82 any chance to have my PR merged? I would like to add support to lookbehind to avoid warnings in chevrotain

@bd82
Copy link
Owner

bd82 commented Nov 16, 2022

Hello @luiz290788

I want to merge this package into the main Chevrotain's mono repo.
Perhaps it would be best to re-create and merge your PR after I've done so.
So:

  1. it would be easier to test E2E.
  2. no unneeded maintenance on a repo I intend to archive (e.g failing release process / updating build process).

@luiz290788
Copy link
Author

@bd82 do you need any help to merge the package into Chevrotain? I can help you with that.

@bd82
Copy link
Owner

bd82 commented Nov 20, 2022

do you need any help to merge the package into Chevrotain? I can help you with that.

@luiz290788 that would be awesome 👍
Try to old add it as is right now with minimal changes, I will later try to convert it to TypeScript.

@luiz290788
Copy link
Author

I've finally started moving the package to inside chevrotain.

@luiz290788 luiz290788 closed this Jun 26, 2023
@bd82
Copy link
Owner

bd82 commented Jul 1, 2023

Hello @luiz290788

regexp-to-ast is not part of the main Chevrotain repo.
You can re-create your PR there (its in typescript now) if you have free time.

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants