Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fixes + jquery extend instead of clone methods #2

Merged
merged 2 commits into from
Jun 30, 2011

Conversation

eroh92
Copy link

@eroh92 eroh92 commented Apr 13, 2011

Fixed a bug where some versions of request change the callback method of toQueue.

Changed cloneAndExtend to be jQuery.extend.

Updated jQuery to use npm version rather than hard coded version.

Justin Van Winkle added 2 commits April 12, 2011 22:51
- moved innerHTML creation up into jsdom constructor
- fixed a bug where request was changing the callback method on the toQueue objects
@jhurliman
Copy link
Contributor

What is the status on this?

@jhurliman
Copy link
Contributor

By the way, jQuery.extend and cloneAndExtend have different semantics, and commit f4101f9 appears to break node-crawler. From the jQuery docs:

"Keep in mind that the target object (first argument) will be modified, and will also be returned from $.extend(). If, however, we want to preserve both of the original objects, we can do so by passing an empty object as the target:

var object = $.extend({}, object1, object2);"

This patch causes the queue() function to continually overwrite the properties in this.options, causing erratic behavior.

@sylvinus sylvinus merged commit f4101f9 into bda-research:master Jun 30, 2011
mike442144 pushed a commit that referenced this pull request Jan 5, 2018
use python3 and later node-stretch
mike442144 pushed a commit that referenced this pull request Nov 23, 2020
Miniast added a commit that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants