Refactor conflict handling flow to be less back-and-forth #957
GitHub Actions / Test Results (Windows, SingleThread)
failed
Oct 12, 2023 in 0s
Test Results (Windows, SingleThread) ❌
❌ TestResults-Windows-SingleThread.trx
5046 tests were completed in 1812s with 5030 passed, 1 failed and 15 skipped.
| Test suite | Passed | Failed | Skipped | Time |
|---|---|---|---|---|
| osu.Game.Tests.Visual.Settings.TestSceneKeyBindingPanel | 16✔️ | 1❌ | 3s |
❌ osu.Game.Tests.Visual.Settings.TestSceneKeyBindingPanel
✔️ TestBindingConflictCausedByResetToDefaultOfSingleRow
❌ TestBindingConflictResolvedByOverwrite
TearDown : osu.Framework.Testing.Drawables.Steps.AssertButton+TracedException : Check Left (centre) is bound to : Expected string length 0 but was 2. Strings differ at index 0.
Expected: <string.Empty>
But was: "M1"
-----------^
✔️ TestBindingConflictResolvedByRollback
✔️ TestBindingMouseWheelToGameplay
✔️ TestBindingMouseWheelToNonGameplay
✔️ TestBindingSingleKey
✔️ TestBindingSingleKeyWithModifier
✔️ TestBindingSingleModifier
✔️ TestBindingTwoNonModifiers
✔️ TestClearButtonOnBindings
✔️ TestClickRowSelectsFirstBinding
✔️ TestClickTwiceOnClearButton
✔️ TestConstructor
✔️ TestFilteringHidesResetSectionButtons
✔️ TestResetAllBindingsButton
✔️ TestResettingEntireSectionDoesNotCauseBindingConflicts
✔️ TestSingleBindingResetButton
Annotations
Check failure on line 0 in TestResults-Windows-SingleThread.trx
github-actions / Test Results (Windows, SingleThread)
osu.Game.Tests.Visual.Settings.TestSceneKeyBindingPanel ► TestBindingConflictResolvedByOverwrite
Failed test found in:
TestResults-Windows-SingleThread.trx
Error:
TearDown : osu.Framework.Testing.Drawables.Steps.AssertButton+TracedException : Check Left (centre) is bound to : Expected string length 0 but was 2. Strings differ at index 0.
Expected: <string.Empty>
But was: "M1"
-----------^
Raw output
TearDown : osu.Framework.Testing.Drawables.Steps.AssertButton+TracedException : Check Left (centre) is bound to : Expected string length 0 but was 2. Strings differ at index 0.
Expected: <string.Empty>
But was: "M1"
-----------^
--TearDown
at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
at osu.Framework.Threading.Scheduler.Update()
at osu.Framework.Graphics.Drawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Platform.GameHost.UpdateFrame()
at osu.Framework.Threading.GameThread.processFrame()
at osu.Framework.Threading.GameThread.RunSingleFrame()
at osu.Framework.Platform.ThreadRunner.RunMainLoop()
at osu.Framework.Platform.GameHost.windowUpdate()
at osu.Framework.Platform.GameHost.Run(Game game)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)
Loading