Use dimmed placeholder text instead of empty box on cleared bindings #959
GitHub Actions / Test Results (Linux, MultiThreaded)
failed
Oct 12, 2023 in 1s
Test Results (Linux, MultiThreaded) ❌
❌ TestResults-Linux-MultiThreaded.trx
5046 tests were completed in 1465s with 5028 passed, 3 failed and 15 skipped.
| Test suite | Passed | Failed | Skipped | Time |
|---|---|---|---|---|
| osu.Game.Tests.Visual.Settings.TestSceneKeyBindingPanel | 14✔️ | 3❌ | 3s |
❌ osu.Game.Tests.Visual.Settings.TestSceneKeyBindingPanel
❌ TestBindingConflictCausedByResetToDefaultOfSingleRow
TearDown : osu.Framework.Testing.Drawables.Steps.AssertButton+TracedException : Check Left (rim) is bound to : Expected string length 0 but was 6. Strings differ at index 0.
Expected: <string.Empty>
But was: "(none)"
-----------^
❌ TestBindingConflictResolvedByOverwrite
TearDown : osu.Framework.Testing.Drawables.Steps.AssertButton+TracedException : Check Left (centre) is bound to : Expected string length 0 but was 6. Strings differ at index 0.
Expected: <string.Empty>
But was: "(none)"
-----------^
✔️ TestBindingConflictResolvedByRollback
✔️ TestBindingMouseWheelToGameplay
✔️ TestBindingMouseWheelToNonGameplay
✔️ TestBindingSingleKey
✔️ TestBindingSingleKeyWithModifier
✔️ TestBindingSingleModifier
✔️ TestBindingTwoNonModifiers
❌ TestClearButtonOnBindings
TearDown : osu.Framework.Testing.Drawables.Steps.AssertButton+TracedException : first binding cleared
✔️ TestClickRowSelectsFirstBinding
✔️ TestClickTwiceOnClearButton
✔️ TestConstructor
✔️ TestFilteringHidesResetSectionButtons
✔️ TestResetAllBindingsButton
✔️ TestResettingEntireSectionDoesNotCauseBindingConflicts
✔️ TestSingleBindingResetButton
Annotations
Check failure on line 0 in TestResults-Linux-MultiThreaded.trx
github-actions / Test Results (Linux, MultiThreaded)
osu.Game.Tests.Visual.Settings.TestSceneKeyBindingPanel ► TestBindingConflictCausedByResetToDefaultOfSingleRow
Failed test found in:
TestResults-Linux-MultiThreaded.trx
Error:
TearDown : osu.Framework.Testing.Drawables.Steps.AssertButton+TracedException : Check Left (rim) is bound to : Expected string length 0 but was 6. Strings differ at index 0.
Expected: <string.Empty>
But was: "(none)"
-----------^
Raw output
TearDown : osu.Framework.Testing.Drawables.Steps.AssertButton+TracedException : Check Left (rim) is bound to : Expected string length 0 but was 6. Strings differ at index 0.
Expected: <string.Empty>
But was: "(none)"
-----------^
--TearDown
at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
at osu.Framework.Threading.Scheduler.Update()
at osu.Framework.Graphics.Drawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Platform.GameHost.UpdateFrame()
at osu.Framework.Threading.GameThread.processFrame()
at osu.Framework.Threading.GameThread.RunSingleFrame()
at osu.Framework.Threading.GameThread.<createThread>g__runWork|66_0()
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
Check failure on line 0 in TestResults-Linux-MultiThreaded.trx
github-actions / Test Results (Linux, MultiThreaded)
osu.Game.Tests.Visual.Settings.TestSceneKeyBindingPanel ► TestBindingConflictResolvedByOverwrite
Failed test found in:
TestResults-Linux-MultiThreaded.trx
Error:
TearDown : osu.Framework.Testing.Drawables.Steps.AssertButton+TracedException : Check Left (centre) is bound to : Expected string length 0 but was 6. Strings differ at index 0.
Expected: <string.Empty>
But was: "(none)"
-----------^
Raw output
TearDown : osu.Framework.Testing.Drawables.Steps.AssertButton+TracedException : Check Left (centre) is bound to : Expected string length 0 but was 6. Strings differ at index 0.
Expected: <string.Empty>
But was: "(none)"
-----------^
--TearDown
at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
at osu.Framework.Threading.Scheduler.Update()
at osu.Framework.Graphics.Drawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Platform.GameHost.UpdateFrame()
at osu.Framework.Threading.GameThread.processFrame()
at osu.Framework.Threading.GameThread.RunSingleFrame()
at osu.Framework.Threading.GameThread.<createThread>g__runWork|66_0()
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
Check failure on line 0 in TestResults-Linux-MultiThreaded.trx
github-actions / Test Results (Linux, MultiThreaded)
osu.Game.Tests.Visual.Settings.TestSceneKeyBindingPanel ► TestClearButtonOnBindings
Failed test found in:
TestResults-Linux-MultiThreaded.trx
Error:
TearDown : osu.Framework.Testing.Drawables.Steps.AssertButton+TracedException : first binding cleared
Raw output
TearDown : osu.Framework.Testing.Drawables.Steps.AssertButton+TracedException : first binding cleared
--TearDown
at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
at osu.Framework.Threading.Scheduler.Update()
at osu.Framework.Graphics.Drawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Platform.GameHost.UpdateFrame()
at osu.Framework.Threading.GameThread.processFrame()
at osu.Framework.Threading.GameThread.RunSingleFrame()
at osu.Framework.Threading.GameThread.<createThread>g__runWork|66_0()
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
Loading