Skip to content

Fix crash when switching tracks back and forth with shuffle on #1685

Fix crash when switching tracks back and forth with shuffle on

Fix crash when switching tracks back and forth with shuffle on #1685

GitHub Actions / Test Results (Linux, SingleThread) failed Oct 11, 2024 in 0s

10559 passed, 1 failed and 74 skipped

Tests failed

❌ TestResults-Linux-SingleThread.trx

10634 tests were completed in 1880s with 10559 passed, 1 failed and 74 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Visual.Menus.TestSceneMusicActionHandling 11✅ 1❌ 16s

❌ osu.Game.Tests.Visual.Menus.TestSceneMusicActionHandling

✅ TestConstructor
✅ TestConstructor
✅ TestMusicNavigationActions
✅ TestMusicNavigationActions
✅ TestMusicPlayAction
✅ TestMusicPlayAction
✅ TestShuffleBackAndForth
❌ TestShuffleBackAndForth
	"track changed" timed out
✅ TestShuffleBackwards
✅ TestShuffleBackwards
✅ TestShuffleForwards
✅ TestShuffleForwards

Annotations

Check failure on line 541 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Linux, SingleThread)

osu.Game.Tests.Visual.Menus.TestSceneMusicActionHandling ► TestShuffleBackAndForth

Failed test found in:
  TestResults-Linux-SingleThread.trx
Error:
  "track changed" timed out
Raw output
"track changed" timed out
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /home/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 541
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)