fix boolean handling #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the boolean handling in two ways: - it uses the flag's enabled status as the source of truth if the value is nil - it treats a blank string as true These changes are to accomodate quirks of setting flag values in the Flagsmith web UI.
bdchauvette
commented
Oct 2, 2024
Comment on lines
+8
to
+17
| # When a flag is first created, Flagsmith sets the value to nil, and | ||
| # as long as the value is never changed through the UI, the value will | ||
| # stay as nil. In this case, the flag's enabled status should be used | ||
| # as the value of the flag. | ||
| # | ||
| # Note that in practice this particular code path SHOULD always return | ||
| # `true`, because the resolver bails out early and uses a default | ||
| # value if the flag is disabled. However, for the sake of correctness, | ||
| # we should still explicitly check the flag's enabled status here. | ||
| return flag.enabled? if value.nil? |
There was a problem hiding this comment.
Note that there is currently a bug in Flagsmith's ruby SDK that converts false flag values to nil:
value: json_flag_data[:feature_state_value] || json_flag_data[:value],I plan to open a PR upstream to fix that issue, but for now it means that fetch_boolean_value will always return true for an enabled flag that is explicitly set to false in the Flagsmith UI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the boolean handling in two ways:
These changes are to accomodate quirks of setting flag values in the Flagsmith web UI.