[Objective-C] Replace NSMutableArray with CFMutableArray #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denizak
changed the title
|
Thanks for submitting this. I's been a long time since I written Objective-C, so I need some context here. What is the difference between the NS and CF variants? Why is this change better for performance? Have some timings to back it up? Thanks. |
|
attached runtime test using Macbook Intel i5 
NSMutableArray finish at 36s |
|
OK, but I still need further explanation of what the change is actually doing, please! |
|
This PR is about changing the usage of NSMutableArray into CFMutableArray. Using the non-retaining CFMutableArray to make the process faster and reduce the retain time of each object being append to the array. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.