Make runner check for explicit executable #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've now merged with latest main. And also sorted the run.sh languages alphabetically, because it was quite hard to merge things and not miss something when things where unsorted. |
The runner doesn't currently work for all languages, because how they differ in what exectable file they use. This PR adds and argument to the run commands so that they point at the correct executable file. I also change so that the input file is used for all benchmark. Even if it is an empty file for hello-world. Plus, making the run.sh script take arguments that can override the the input file. To make it easier to test the runner with faster executing arguments.
|
Thanks @PEZ! I will get to this... at some point! |
|
I've made some changes myself to the run.sh script which addresses some of these issues. For example, I think the issue of knowing where the file to execute is is now resolved. Maybe if we do a zoom call we can chat about this then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runner doesn't currently work for all languages, because how they differ in what executable file they use. It's the thing we discussed here
(Even if I don't think we agreed that things need to be fixed. 😄 Here's a fix anyway.)
This PR adds and argument to the run commands so that they point at the correct benchmark executable file (or script, when that's the case). Plus reverts the way that we currently split up the benchmark command and it's arguments. The run function now also reports when it can't find a compiled executable or script for the benchmark.
Please note that for some of the languages the actual compiled executable is mine and ChatGPTs best guess, so we probably need to verify this somehow. I believe you have almost all toolchains setup on your machine, @bddicken? If so maybe you are best positioned to verify. I am in the process of setting up more (hopefully all) toolchains, but it will take me a while.
Some more changes of the run.sh script: