Dart improvements to Levenshtein challenge, roughly 47% faster #265
+30
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes to the Levenshtein challenge, Dart solution.
The individual commits describe the steps:
The majority of the improvements are due to the inner list using
Int16List, though the other two commits (outer list not growable, and extracting the row into its own variable) also consistently performed a couple of % better.I also formatted the code. In Dart, it's standard to use the built-in Dart tooling for formatting Dart source code.
On my machine, these changes make the Dart code roughly the same speed as Swift.
Languages that were previously faster, but are now (with my changes) slower than Dart: Java, LuaJIT, C#, Bun (using this tweet as a reference).