perf: reduce string comparisons in Levenshtein distance calculation #266
+18
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perf: optimize Levenshtein distance implementation - Move first row initialization to compile time using inline while - Cache characters to reduce array access - Use @intFromBool for cost calculation - Eliminate redundant string comparisons by starting j at i+1 - Use maxInt(usize) instead of -1 for min_distance - Improve type safety by using usize consistently Performance: Reduces number of comparisons from n*(n-1) to n*(n-1)/2
|
Hi! I don't think we are allowed to do 1 and 3. The output of this version is Which is only half of the work the reference implementations do. The benchmark tries to measure how fast a language does some work, and it's probably also cheating to do the work beforehand. (But @bddicken be the judge!) Making string access more efficient should be perfectly fine, though. Do you know how much performance that unlocks? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize Levenshtein distance algorithm performance
Key changes: