Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shaderc
, andspirv_cross
also needed to be bumped.find_program
is no longer used to findflatc
,impellerc
, orshader_archive
from the path. Instead, these executables can be overridden with-DFLATBUFFERS_FLATC_EXECUTABLE=/path/to/my/flatc
,-DIMPELLERC_EXECUTABLE=/path/to/my/impellerc
, and-DIMPELLER_SHADER_ARCHIVE_EXECUTABLE=/path/to/my/shader_archive
respectively. This is to make the default build much more likely to succeed. For example: Generated flatbuffers need to match up with the exact version of the C++ header, so usingfind_program
to findflatc
as the default behavior will lead to build failures in most situations whereflatc
is successfully found.