Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Impeller to ToT #24

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Update Impeller to ToT #24

merged 1 commit into from
Feb 22, 2024

Conversation

bdero
Copy link
Owner

@bdero bdero commented Feb 16, 2024

  • Bump flutter engine. shaderc, and spirv_cross also needed to be bumped.
  • find_program is no longer used to find flatc, impellerc, or shader_archive from the path. Instead, these executables can be overridden with -DFLATBUFFERS_FLATC_EXECUTABLE=/path/to/my/flatc, -DIMPELLERC_EXECUTABLE=/path/to/my/impellerc, and -DIMPELLER_SHADER_ARCHIVE_EXECUTABLE=/path/to/my/shader_archive respectively. This is to make the default build much more likely to succeed. For example: Generated flatbuffers need to match up with the exact version of the C++ header, so using find_program to find flatc as the default behavior will lead to build failures in most situations where flatc is successfully found.

@bdero bdero merged commit 545686e into master Feb 22, 2024
1 of 2 checks passed
@bdero
Copy link
Owner Author

bdero commented Feb 22, 2024

(FYI @johnoneil)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant