fix: Correctly disable DropDownButton items if onPressed is not p…

…rovided (#1116)
bdlukaa · Sep 29, 2024 · bde4752 · bde4752
1 parent 2a2fc6d
commit bde4752
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 - fix : The EditableComboBox is missing the part that applies the style to the TextBox, so add it.
 - feat: Add `BreadcrumbBar.chevronIconBuilder` and `BreadcrumbBar.chevronIconSize` ([#1111](https://github.com/bdlukaa/fluent_ui/issues/1111))
 * fix: Consider object translation on Menu Flyouts ([#1104](https://github.com/bdlukaa/fluent_ui/issues/1104))
+* fix: Correctly disable `DropDownButton` items if `onPressed` is not provided ([#1116](https://github.com/bdlukaa/fluent_ui/issues/1116#issuecomment-2347153074))
 
 ## 4.9.1
 

diff --git a/example/lib/screens/inputs/button.dart b/example/lib/screens/inputs/button.dart
@@ -270,7 +270,7 @@ ToggleButton(
   items: [
     MenuFlyoutItem(text: const Text('Send'), onPressed: () {}),
     MenuFlyoutSeparator(),
-    MenuFlyoutItem(text: const Text('Reply'), onPressed: () {}),
+    MenuFlyoutItem(text: const Text('Reply'), onPressed: null),
     MenuFlyoutItem(text: const Text('Reply all'), onPressed: () {}),
   ],
 )''',
@@ -280,7 +280,7 @@ ToggleButton(
               items: [
                 MenuFlyoutItem(text: const Text('Send'), onPressed: () {}),
                 MenuFlyoutSeparator(),
-                MenuFlyoutItem(text: const Text('Reply'), onPressed: () {}),
+                MenuFlyoutItem(text: const Text('Reply'), onPressed: null),
                 MenuFlyoutItem(text: const Text('Reply all'), onPressed: () {}),
               ],
             ),

diff --git a/lib/src/controls/inputs/dropdown_button.dart b/lib/src/controls/inputs/dropdown_button.dart
@@ -373,9 +373,7 @@ class DropDownButtonState extends State<DropDownButton> {
 
   MenuFlyoutItem _createMenuItem(MenuFlyoutItem item, BuildContext context) {
     return MenuFlyoutItem(
-      onPressed: () {
-        item.onPressed?.call();
-      },
+      onPressed: item.onPressed,
       closeAfterClick: widget.closeAfterClick,
       key: item.key,
       leading: item.leading,