Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added NavigationView.onItemPressed callback, called when item is on tap. #1067

Merged
merged 2 commits into from
May 31, 2024
Merged

feat: Added NavigationView.onItemPressed callback, called when item is on tap. #1067

merged 2 commits into from
May 31, 2024

Conversation

CorvusYe
Copy link
Contributor

NavigationView.onItemPressed

When the same index is clicked, we hope to have a response event.
So I extended the onItemPressed method on the basis of onChanged.

As shown in the example, it is possible to control whether to open or compact the effects.

Pre-launch Checklist

  • I have updated CHANGELOG.md with my changes
  • I have run "dart format ." on the project
  • I have added/updated relevant documentation

bdlukaa
bdlukaa approved these changes May 31, 2024
View reviewed changes
Copy link
Owner

@bdlukaa bdlukaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

lib/src/controls/navigation/navigation_view/pane.dart Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@bdlukaa bdlukaa merged commit 32ec723 into bdlukaa:master May 31, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdlukaa bdlukaa bdlukaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CorvusYe @bdlukaa