fix: Update NumberBox formatting pattern for precision #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! Would you mind adding this to the CHANGELOG? |
|
Sure, but I just realized that this PR is a bit too simple, and I would like to add some more content:
It seems that the PR has also failed to merge, so I will find some time later to complete this part and then modify the CHANGLOG.. Is that okay? |
|
Sounds okay to me! |
…at` to Numberbox.
|
@FourLeafTec let me known when this is ready for review! |
|
@bdlukaa It‘s ok now, and feedback is welcome. |
bdlukaa
requested changes
Jul 8, 2024
Co-authored-by: Bruno D'Luka <45696119+bdlukaa@users.noreply.github.com>
Co-authored-by: Bruno D'Luka <45696119+bdlukaa@users.noreply.github.com>
…BoxFormatFunction NumberBoxFormatter
|
@bdlukaa Review please. |
bdlukaa
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1079 .
By add NumberFormat pattern L632.