Fix: PaneItem Behavior in Compact Mode
#1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ionPane` **Description:** This Pull Request addresses the issue where `PaneItem` widgets with `enabled: false` are still accessible when the `NavigationPane` is in `PaneDisplayMode.compact` mode. **Changes Made:** - Modified `pane_items.dart` to ensure that `onPressed` and `forceEnabled` values are correctly passed based on the `item.enabled` property. - Updated the `builder` to merge the theme of the icon and title based on the `states`. **Issue Reference:** This PR resolves the bug where disabled `PaneItem` widgets can be navigated to when the `NavigationPane` is in compact mode, as described in the related issue: bdlukaa#1081
Screenshots
|
bdlukaa
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Disabled
PaneItemStill Accessible in Compact Mode ofNavigationPaneDescription:
This Pull Request addresses the issue where
PaneItemwidgets withenabled: falseare still accessible when theNavigationPaneis inPaneDisplayMode.compactmode.Changes Made:
pane_items.dartto ensure thatonPressedandforceEnabledvalues are correctly passed based on theitem.enabledproperty.builderto merge the theme of the icon and title based on thestates.Issue Reference:
This PR resolves the bug where disabled
PaneItemwidgets can be navigated to when theNavigationPaneis in compact mode, as described in the related issue: #1081Pre-launch Checklist
CHANGELOG.mdwith my changes