Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add build workflows #753

Merged
merged 9 commits into from
Mar 7, 2023
Merged

add build workflows #753

merged 9 commits into from
Mar 7, 2023

Conversation

bdlukaa
Copy link
Owner

@bdlukaa bdlukaa commented Mar 4, 2023

Pre-launch Checklist

  • I have updated CHANGELOG.md with my changes
  • I have run "dart format ." on the project
  • I have added/updated relevant documentation

@h3x4d3c1m4l
Copy link
Contributor

lmk if you would like any help with macOS!

@bdlukaa
Copy link
Owner Author

bdlukaa commented Mar 7, 2023

I don't think it makes sense to have a build workflow for platforms other than windows

@h3x4d3c1m4l
Copy link
Contributor

h3x4d3c1m4l commented Mar 7, 2023

Well looking from "Microsoft perspective", it probably doesn't cause Fluent UI is designed for Windows. However, due to Flutter's nature being a multiplatform UI framework, it could make sense. There is nothing in fluent_ui that stops me from running my fluent_ui based apps on macOS. It even looks pretty nice too 😄

On the other hand there are pretty good reasons you could indeed ignore other platforms:

  • As of now you still need macOS to compile for macOS, and macOS minutes on GH Actions are expensive
  • You do not own a mac currently, thus maintenance would be community based

@bdlukaa
Copy link
Owner Author

bdlukaa commented Mar 7, 2023

I ended up adding the build workflow for it, just for precaution.

As of now you still need macOS to compile for macOS, and macOS minutes on GH Actions are expensive

They aren't charged on public repos

@bdlukaa bdlukaa merged commit 16a910d into master Mar 7, 2023
@bdlukaa bdlukaa deleted the workflows branch March 26, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants