Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make FluentApp.routers color property optional #783

Merged
merged 3 commits into from
Mar 24, 2023
Merged

Make FluentApp.routers color property optional #783

merged 3 commits into from
Mar 24, 2023

Conversation

jtdLab
Copy link
Contributor

@jtdLab jtdLab commented Mar 19, 2023

Fix #782

  • I have updated CHANGELOG.md with my changes
  • I have run "dart format ." on the project

@jtdLab jtdLab changed the title App router color optional Make FluentApp.routers color property optional Mar 19, 2023
WinXaito
WinXaito approved these changes Mar 23, 2023
View reviewed changes
Copy link
Collaborator

@WinXaito WinXaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtdLab
Copy link
Contributor Author

jtdLab commented Mar 23, 2023

@WinXaito merged master

@WinXaito
Copy link
Collaborator

WinXaito commented Mar 23, 2023 •
edited
Loading

@WinXaito merged master

I just do a review, I let @bdlukaa validate and merge that 😉

@WinXaito WinXaito merged commit fe03672 into bdlukaa:master Mar 24, 2023
@jtdLab jtdLab deleted the app_router_color_optional branch April 7, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WinXaito WinXaito WinXaito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 FluentApp.router has required color property
2 participants
@jtdLab @WinXaito