Use NodeJS modules #387
Draft
Use NodeJS modules #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use type: module - remove unused babel modules - remove webpack configuration
- singleton module export to wrap chalk - the singleton allows mocked/swapped module methods with es6 modules
mrozbarry
added
enhancement
dependencies
- ci reported an incomatibility issue - could not reproduce locally
mrozbarry
force-pushed
the
x-wrap-chalk-and-use-nodejs-modules
branch
from
71e3358 to
ee4c377
Compare
|
@bdo looks like circleci might need to be updated to use node 18 instead of 14. Change is related to bumping up commitlint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a while, I've been getting dependency warning/update emails on this repository, mostly around babel. I think node has mostly gotten to the point where es6 can be used natively without a bunch of build steps.
Well, I am right in theory, but jest doesn't officially support type:module es6 and has a few experimental/hacky solutions.
I also noticed that test coverage was pretty low, so I may up that coverage while I'm here.