This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
feat: make isal optional and installed only as an extra #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have problems detecting i686 during image builds because they are done on x86_64 machines. To avoid this issue isal is now an extra and needs to be installed as `pip install aiohttp-zlib-ng[isal]`
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
==========================================
+ Coverage 71.42% 80.95% +9.52%
==========================================
Files 1 1
Lines 21 21
Branches 4 4
==========================================
+ Hits 15 17 +2
+ Misses 4 2 -2
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have problems detecting i686 during image builds because they are done on x86_64 machines. To avoid this issue isal is now an extra and needs to be installed as
pip install aiohttp-zlib-ng[isal]