-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FRAC feature: parsing and mis-identifying which chars are part of the fraction, when non-digits present #2214
Comments
Wow, thanks! |
Could those work also with U+2044, and separators comma and U+202F (narrow no-break space)? Maybe also separators U+2007 (figure space), U+2008 (punctuation space), U+2009 (thin space), U+200A (hair space)? Meaning, even without frac activated, the use of U+2044 with digits and those sepators, trigger the frac behavior? Regular space and non-breaking space (or any other character) should break the fraction, IMO. Also, thanks, great work! I never saw another font that treats the dot as part of the fractions, but I think all should (and at least the comma too) |
I disagree. If anything, non-breaking space and narrow non-breaking space would be the only ones that could potentially carry additional characters up to the numerator or down to the denominator, and either way it's still a non-standard behavior. |
Doable with those two spaces (since they’re all the same width anyways), plus the comma. The dot is not the only decimal separator used, most languages (but not most population) use the comma instead: https://en.wikipedia.org/wiki/Decimal_separator Plus, about the non-standard behaviour, it may be so, but it shouldn’t, IMO, since it’s an ISO standard: https://en.wikipedia.org/wiki/Decimal_separator#Current_standards Since I type a lot of code and technical documents, I added both U+00A0 (at AltGr+space) and U+202F (AltGr+shift+space) to my keyboard layout Also, just remembered, it would be a great thing for the dozenalist community if the fraction behavior worked also on U+218A ↊ and U+218B ↋ (dozenal/duodecimal digits ten and eleven) A final note about the spaces, just if someone from other fonts sees this, is that, if you take the information about how languages use a space as a group separator, instead of the dot or comma, appart from the two non-breaking spaces (full-width and narrow), according to the unicode standard (https://www.unicode.org/charts/PDF/U2000.pdf), U+2008 is a space that is intended to be the width of a full stop (the narrow punctuation mentioned there), so, it could be used to separate digits, and give a nice balance combined with separating the fractional part with the dot or comma; To @jmcwilliams403 |
Ĉi tio estas iom ekstertema, sed mi dankas vian ĝentilecon. |
⭐💚🙏🏻 |
Ok, after some tinkering, some things worked, some others, don’t: By looking at the original commit, I managed to add comma, nbsp and nnbsp to the list of characters that are treated as part of the fraction (the others are for my personal use, and plus and minus are different codepoints for superscript/numerator): list null 'comma' I understood that the null there means the character doesn’t have a unicode code point, but it will exist within the font itself; What I don’t understand is that, why using U+2044 alone doesn’t trigger the same behavior as frac? I allways thought they were practically the same feature, activated in two different ways. It’d be awesome if someone could point me out where to look, so that using U+2044 next to the same characters get the same result as using frac at the font level. Thanks! |
I don't know if this logic is part of the font, or rather outside the scope of Iosevka, but using the FRAC feature can mis-identify which characters should be part of a fraction, when there are non-digit characters involved.
Examples:
The text was updated successfully, but these errors were encountered: