Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using [buildPlans.iosevka-custom.weights.bold] in private-build-plans.toml the build process finishes succesfully but there are no bold variants built #474

Closed
wimstefan opened this issue Apr 4, 2020 · 5 comments

Comments

@wimstefan
Copy link

  • Your font version: git dev commit f18c366
  • Your font variant: customized Iosevka
  • Your operating system (name and version): Gentoo ~amd64
  • Your application using Iosevka: kitty, alacritty, awesomewm

If you have problem when building Iosevka, please provide these information:

  • Your Node.js version: v13.12.0
  • Your otfcc version: 0.10.3
  • Your private-build-plans.toml, if present:
[buildPlans.iosevka-artesanal]
family = "Iosevka Artesanal"
design = [
  "artesanal",
  "sp-term",
  "v-f-tailed",
  "v-g-opendoublestorey",
  "v-i-serifed",
  "v-k-curly",
  "v-l-serifed",
  "v-q-taily",
  "v-m-shortleg",
  "v-r-top-serifed",
  "v-capital-r-curly",
  "v-eszet-traditional",
  "v-u-with-bar",
  "v-v-curly",
  "v-w-curly",
  "v-y-cursive",
  "v-capital-y-curly",
  "v-x-cursive",
  "v-zero-reverse-slashed",
  "v-three-flattop",  "v-seven-serifed",
  "v-tilde-high",
  "v-asterisk-high",
  "v-paragraph-high",
  "v-caret-high"
]
[buildPlans.iosevka-artesanal.weights.bold]
shape = 600
menu  = 600
css   = 600
  • Your private.toml, paste if modified:
[artesanal]
slantAngle = 0
[s-italic]
slantAngle = 8
[s-oblique]
slantAngle = 8
[artesanal.multiplies]
sb = 0.90
width = 0.90

I've build my own customized font with the parameters above the issues as described in #473 and there is no bold variant built at all.

@be5invis
Copy link
Owner

be5invis commented Apr 4, 2020

[buildPlans.iosevka-artesanal.weights.bold]
shape = 600
menu  = 600
css   = 600

The menu entry will change the font's name and OS' weight identification, so software will think this font is "Semibold". To change shape only, do this:

[buildPlans.iosevka-artesanal.weights.bold]
shape = 600
menu  = 700
css   = 700

@be5invis
Copy link
Owner

be5invis commented Apr 4, 2020

If you are curious about why the "menu" option exists — this allows you to define new weights like Book and assign a weight like 450 to it.

@wimstefan
Copy link
Author

Very interesting! Thanks for the explanation and your patience - I'm just a simple user who enjoys the possibility to customize his fonts ... unfortunately without completely understanding how it works 😔
I've also noticed that if you use a different weight definition than you have to define all weights otherwise just the weight defined is also built. That wasn't obvious to me when I read the Readme ...
Sorry for being so ignorant - I really try to do my best.

@be5invis
Copy link
Owner

be5invis commented Apr 6, 2020

@wimstefan
A weight definition in the configuration file will make the build system create files for one weight, and the parameters will decide in the built font files, how thick will the strokes be (shape field), how is it named (menu field), and what is the corresponded CSS weight if you decide to make the web font CSS (css field).
Yes the weight override needs to define all the weights, so you can build a subset of weights.
PRs are welcome to provide a better description.

@wimstefan
Copy link
Author

Hmm perhaps it makes sense to add one more line like this:

  diff --git a/README.md b/README.md
  index 52e7e72..0e3f0e0 100644
  --- a/README.md
  +++ b/README.md
  @@ -84,6 +84,7 @@ Since version 2.0, Iosevka would no longer support building via `makefile`. To i
      # All weights would built and mapped to default shape/CSS
      # IMPORTANT : Currently "menu" property only support 100, 200, 300, 400, 450, 500, 600, 700, 800, 900.
      #              and "shape" properly only supports number between 100 and 900 (inclusive).
  +   #             *If* you decide to use custom weights you have to define all the weights you plan to use otherwise they will not be built.
      [buildPlans.iosevka-custom.weights.regular]
      shape = 400  # Weight for glyph shapes
      menu  = 400  # Weight for menu name

@be5invis be5invis closed this as completed Apr 7, 2020
black-black-cat added a commit to black-black-cat/Iosevka that referenced this issue Apr 18, 2020
* More arrow fixup

* Add more detailed docs for building. Fixes be5invis#474

* Add docs for width customization

* Update Node.JS version requirement. Fixes be5invis#486

* Fix phonetic ligatures' shape. Now they are connected more closely (be5invis#488).

* Remove unused logs

* Fix LATIN SMALL LETTER TC DIGRAPH WITH CURL overflow

* Fix shape of U+AB30, U+AB64 and U+1DE7 (be5invis#489).

* Docs: fix required otfcc version (be5invis#490)

* Make dot removal work if a below or other mark is between the base and above mark

* Fix export of U+478 and U+479

* Make "ligtions using dlig and calt at same time" less strange

* Fixup format

* Fix shape of U+029A, U+1D08, U+1D4C (be5invis#491).

* remove "ai" knots

* Add U+AB66 and U+AB67 (be5invis#488).

* Force f-eng to be connected

* Add [reverse-rule] to simplify reverse subst code

* Make GSUB more efficient

* Need to keep correspondence

* Fix shape of U+1DF0 (be5invis#497).

* Adjust length of diagonal arrows

* Make double arrow only work with arrow2 selector

* Add ligation for shift-equal operators (>>=, <<=, >>>=, <<<=)

* Update visualization data

* Add ligation group "CLIK"

* Add warning about auto-generated README sections

* Add overrideSupportedLanguages list

* Bump version

* Fix incorrect sample images of ligations

Co-authored-by: Belleve Invis <belleve@typeof.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants