Skip to content

Refactor theme handling to use shared tokens #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Refactor theme handling to use shared tokens #173

wants to merge 2 commits into from

Conversation

@beNative
Copy link
Owner

Summary

  • add centralized theme token definitions with helpers for the light and dark palettes
  • create a theme service that applies the tokens, supports overrides, and manages the root dark class
  • refactor the theme context to use the service, expose a setTheme API, and keep fallbacks in sync via tests

Testing

  • npx vitest run themes/tests/themeTokens.test.ts
  • npx vitest run services/preview/tests/markdownRenderer.test.tsx
  • npx tsc --noEmit (fails: existing type errors in unrelated files)

https://chatgpt.com/codex/tasks/task_e_68fb921402f08332a7c92f472496210f

@beNative beNative closed this Oct 25, 2025
@beNative beNative deleted the codex/create-theme-management-system branch October 25, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@beNative