Store package names in arrow metadata #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericphanson
requested review from
jrevels,
omus and
kleinschmidt
as code owners
ericphanson
commented
Aug 28, 2024
ericphanson
commented
Aug 28, 2024
|
good call @kleinschmidt, I've switched this to use the schema-version instead of the schema name (defined in the |
|
@ericphanson you probably also want to include the version of the package as well since older or newer versions may be incompatible. |
omus
reviewed
Aug 30, 2024
Co-authored-by: Curtis Vogt <curtis.vogt@gmail.com>
omus
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
mostly agree with @omus review and have left comments where I don't. needs a version bump.
Co-authored-by: Curtis Vogt <curtis.vogt@gmail.com>
|
sorry for the delay, I think I've addressed all the review feedback. I'll plan to merge in a day or two if there's no more review changes. |
omus
approved these changes
Oct 23, 2024
Co-authored-by: Curtis Vogt <curtis.vogt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for more informative unknown schema errors
closes #46
Here I chose to only store this information when the schema was defined in a package (rather than in Main or in a script or something), since it's only in that case we can reliably make a suggestion to load that package.