Extend contains from Base when defined
#41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is "new" in Julia 1.5. This change will avoid breaking the package on Julia nightly.
jrevels
approved these changes
Apr 17, 2020
ararslan
added a commit
that referenced
this pull request
Apr 17, 2020
Since we have type piracy on types from Dates to allow them to act like `TimeSpan`s, they could be used in `contains` until the signature was restricted to `AbstractTimeSpan`s in #41 to mitigate breakage from `contains` being reintroduced to Base.
ararslan
added a commit
that referenced
this pull request
Apr 17, 2020
Since we have type piracy on types from Dates to allow them to act like `TimeSpan`s, they could be used in `contains` until the signature was restricted to `AbstractTimeSpan`s in #41 to mitigate breakage from `contains` being reintroduced to Base.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is "new" in Julia 1.5 (JuliaLang/julia#35132). This change will avoid breaking the package on Julia nightly.