-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand supported RayError
exceptions
#221
Conversation
Codecov Report
@@ Coverage Diff @@
## main #221 +/- ##
==========================================
+ Coverage 97.42% 97.64% +0.22%
==========================================
Files 12 12
Lines 660 808 +148
==========================================
+ Hits 643 789 +146
- Misses 17 19 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Ugh, my merge wasn't so clean as it appeared |
Weird formatter failure:
|
3rd run of the formatting workflow worked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few comments. I didn't review this very carefully but let's just merge and wrap this bit up.
Alright, finally going to merge this PR. I need to bump the version yet but I'll let CI finish first. |
Creates Julia exceptions to mirror the Ray exceptions supported by Ray for Python.
One challenge with porting thing is that some exceptions are MessagePack serialized containing pickle5 data. As we found out in #191 we can somewhat read the content without having to unpack it. I've opted to show users the
repr
'd formatted raw data for any exception we haven't seen before. This way users can complain about the bad errors and provide us with examples we can add to our test suites.There is also some future work to be done around adding in call site information from Julia so we can deserialize that information on the driver and report it to the user. I've opted to leave that for now.