Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support inlining task arguments #72

Merged
merged 27 commits into from
Sep 5, 2023
Merged

Support inlining task arguments #72

merged 27 commits into from
Sep 5, 2023

Commits on Sep 1, 2023

  1. Support RayConfig

    @omus
    omus committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    30d2abe View commit details
    Browse the repository at this point in the history

  2. Rough first pass on prepare_task_args

    @omus
    omus committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    1dd4e56 View commit details
    Browse the repository at this point in the history

  3. Support rpc::Address

    @omus
    omus committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    57cb3fa View commit details
    Browse the repository at this point in the history

  4. Support TaskArg

    @omus
    omus committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    f36b06a View commit details
    Browse the repository at this point in the history

  5. Support constructable RayObject

    @omus
    omus committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    5185e71 View commit details
    Browse the repository at this point in the history

  6. Support GetCoreWorker

    @omus
    omus committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    c8e7875 View commit details
    Browse the repository at this point in the history

  7. Attempt to pass back unique_ptr TaskArg

    @omus
    omus committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    f572822 View commit details
    Browse the repository at this point in the history

  8. Lots of experimentation

    @omus
    omus committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    1f40349 View commit details
    Browse the repository at this point in the history

  9. Functional with segfaults

    @omus
    omus committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    feb71cf View commit details
    Browse the repository at this point in the history

  10. Disable default finalizer

    @omus
    omus committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    a0852b0 View commit details
    Browse the repository at this point in the history

  11. Use TaskArgByReference in prepare_task_args

    @omus
    omus committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    a48db48 View commit details
    Browse the repository at this point in the history

  12. Cleanup

    @omus
    omus committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    9e27f4c View commit details
    Browse the repository at this point in the history

  13. Experiment with shared_ptr 

    Trying to get `push!` for free but converting a shared_ptr to a
unique_ptr is trouble
    @omus
    omus committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    35b7e4c View commit details
    Browse the repository at this point in the history

  14. Extend push! with our custom _push_back

    @omus
    omus committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    68b5372 View commit details
    Browse the repository at this point in the history

  15. Working submit_task

    @omus
    omus committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    2344b1f View commit details
    Browse the repository at this point in the history

  16. Refactoring

    @omus
    omus committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    026b152 View commit details
    Browse the repository at this point in the history

  17. Generate call_site string

    @omus
    omus committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    b5738cb View commit details
    Browse the repository at this point in the history

  18. Add tests

    @omus
    omus committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    2727fd3 View commit details
    Browse the repository at this point in the history

  19. Drop unused GetCoreWorker

    @omus
    omus committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    48b1b65 View commit details
    Browse the repository at this point in the history

  20. fixup! Add tests

    @omus
    omus committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    7623be0 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Add TODO about task_args being an Any vector

    @omus
    omus committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    64c71cb View commit details
    Browse the repository at this point in the history

  2. Manual cleanup of TaskArgs

    @omus
    omus committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    327dd2b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into cv/task-arg-by-value

    @omus
    omus committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    cf8da68 View commit details
    Browse the repository at this point in the history

  4. Add comment about using lambdas for RayConfig

    @omus
    omus committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    8eec7a3 View commit details
    Browse the repository at this point in the history

  5. Comment about use of understore in serialize_args tests

    @omus
    omus committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    c66bea3 View commit details
    Browse the repository at this point in the history

  6. Indentation 

    Co-authored-by: Dave Kleinschmidt <dave.f.kleinschmidt@gmail.com>
    @omus @kleinschmidt
    omus and kleinschmidt authored Sep 5, 2023
    Configuration menu
    Copy the full SHA
    399c917 View commit details
    Browse the repository at this point in the history

  7. Push CxxPtr instead of CxxRef

    @omus
    omus committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    987e22a View commit details
    Browse the repository at this point in the history