Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a RayObject from task_executor #97

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Return a RayObject from task_executor #97

merged 1 commit into from
Sep 8, 2023

Conversation

omus
Copy link
Member

@omus omus commented Sep 7, 2023

Allows us to specify any inlined object references in the return.

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #97 (6a939e3) into main (5c8bfe6) will decrease coverage by 1.72%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
- Coverage   76.08%   74.36%   -1.72%     
==========================================
  Files           8        8              
  Lines         347      355       +8     
==========================================
  Hits          264      264              
- Misses         83       91       +8     
Flag Coverage Δ
Ray.jl 74.36% <0.00%> (-1.72%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/runtime.jl 53.72% <0.00%> (-2.39%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

📢 Have feedback on the report? Share it here.

@omus omus requested a review from kleinschmidt September 8, 2023 14:51
@omus omus marked this pull request as ready for review September 8, 2023 14:51
@omus
Copy link
Member Author

omus commented Sep 8, 2023

As far as codecov is concerned task_executor isn't tested. If we enable --code-coverage=true on the worker processes we can get this for free.

@omus omus requested review from glennmoy and removed request for kleinschmidt September 8, 2023 14:58
@omus omus self-assigned this Sep 8, 2023
@omus omus merged commit 98a6395 into main Sep 8, 2023
4 of 6 checks passed
@omus omus deleted the cv/return-rayobject branch September 8, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants