Add Julia language support (ray-2.31.0)
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add julia function descriptor to proto/cpp * make it compile * Support JuliaFunctionDescriptor in == fallback * Enable debug-level logging on the Ray backend * Add Raylet support for Julia * Return Julia language string * EDIT: modify Java worker_pool tests to run Julia * specify julia executable * fix indent, add log_dir arg missing * also includt log_dir when calling * WIP * Functional worker * Use JULIA_PROJECT * Refactor RuntimeEnvContext changes * Funtional passing in JULIA_PROJECT * Cleanup * Rollback non-required changes * Use exported start_worker * Apply suggestions from code review Signed-off-by: Dave Kleinschmidt <dave.f.kleinschmidt@gmail.com> * use Ray.jl as entrypoint to worker runtime * pass `--startup_token` to julia worker * Drop `DEFAULT_WORKER_EXECUTABLE` from `build_julia_worker_command` (#9) * Runtime environment can specify Julia executable and arguments (#8) * Support specifying runtime env executable * Support specifying runtime env args * Support specifying executable/args via runtime env * Avoid quoting default * Switch to using command in RuntimeEnvContext * Use separate command for Julia * Add TODO about switching to plugin Co-authored-by: Dave Kleinschmidt <dave.f.kleinschmidt@gmail.com> Signed-off-by: Curtis Vogt <curtis.vogt@gmail.com> * Avoid escaping `command_prefix` (#10) * formatting Signed-off-by: Glenn Moynihan <glennmoy@gmail.com> * revert logging level changes and delete dev comments Signed-off-by: Glenn Moynihan <glennmoy@gmail.com> * Remove dev logging statements + todo Signed-off-by: Glenn Moynihan <glennmoy@gmail.com> * Missed some JULIA language support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated version of ray-project#40098 for Ray 2.31.0