Allow HTTP images to show on an HTTPS site #94

freedomtrain · 2016-09-13T15:51:40Z

Operation System:OSX
Beaker Version:Latest from Master

When I go to https://itunes.apple.com/us/artist/the-jimi-hendrix-experience/id62819
The thumb nails for the albums do not show up

pfrazee · 2016-09-13T16:03:22Z

I was able to reproduce.

Apple's site is served over HTTPS (secure), but they're including the images over HTTP (insecure). Beaker's current behavior is not to show the HTTP assets. That may be too severe of a policy.

freedomtrain · 2016-09-13T16:08:14Z

Is there a way to change this in our build of beaker ?

On September 13, 2016 at 9:06:30 AM, Paul Frazee (notifications@github.com) wrote:

I was able to reproduce.

Apple's site is served over HTTPS (secure), but they're including the images over HTTP (insecure). Beaker's current behavior is not to show the HTTP assets. That may be too severe of a policy.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

pfrazee · 2016-09-13T16:18:04Z

I'll relax this policy. Insecure images will be allowed to display, but JS/CSS must remain secure.

freedomtrain · 2016-09-13T16:19:21Z

Thats great !
Thanks !

On September 13, 2016 at 9:18:25 AM, Paul Frazee (notifications@github.com) wrote:

HTTP assets

pfrazee · 2016-09-13T16:27:46Z

This is going to require changes to Electron, which is upstream of me. (See electron/electron#2749). I'll have to put this on the backburner until I have time to make a PR to them.

freedomtrain · 2016-09-16T16:59:23Z

I have been using beaker for the last 4 days.
It is going great.
The only issue I continue to have is that many of the sites have blank images.
Is there a way to allow this in my version of beaker ?

pfrazee · 2016-09-16T18:43:28Z

I'll need to make a change to software that Beaker depends on, but doesn't have control over (Electron). The turn-around time for that kind of change tends to be pretty slow. I'll try to get it done soon, but it'll take some time.

freedomtrain · 2016-09-16T18:45:49Z

Thanks !

On September 16, 2016 at 11:43:48 AM, Paul Frazee (notifications@github.com) wrote:

I'll need to make a change to software that Beaker depends on, but doesn't have control over (Electron). The turn-around time for that kind of change tends to be pretty slow. I'll try to get it done soon, but it'll take some time.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

freedomtrain · 2016-09-28T14:45:37Z

Is this issue fixed in latest release ?

pfrazee · 2016-09-28T14:46:59Z

It's not. I've begun the process that will allow me to fix this, but it's
going to take some time.

On Wed, Sep 28, 2016 at 9:45 AM, fredhampton notifications@github.com
wrote:

Is this issue fixed in latest release ?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#94 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABNhU0aztN6A-m1V2N2r3rOsEcNIt3Meks5qun2SgaJpZM4J71kJ
.

freedomtrain · 2016-09-28T14:47:49Z

ok
thanks !!!

On September 28, 2016 at 7:47:11 AM, Paul Frazee (notifications@github.com) wrote:

It's not. I've begun the process that will allow me to fix this, but it's
going to take some time.

On Wed, Sep 28, 2016 at 9:45 AM, fredhampton notifications@github.com
wrote:

Is this issue fixed in latest release ?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#94 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABNhU0aztN6A-m1V2N2r3rOsEcNIt3Meks5qun2SgaJpZM4J71kJ
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Custom Electron Build (which introduces fix for #94)

pfrazee · 2016-10-18T19:27:26Z

@fredhampton this is finally solved in master. Thank for being patient.

freedomtrain · 2016-10-18T21:33:13Z

Thanks !!!!!

On October 18, 2016 at 12:27:30 PM, Paul Frazee (notifications@github.com) wrote:

@fredhampton this is finally solved in master. Thank for being patient.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

freedomtrain · 2016-10-19T00:53:27Z

I tried the master build and it seems that iTunes images are not showing
Have the changes been pushed to master ?
Do I need to make any changes ?

Thanks !!

On October 18, 2016 at 12:27:30 PM, Paul Frazee (notifications@github.com) wrote:

@fredhampton this is finally solved in master. Thank for being patient.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

pfrazee · 2016-10-19T02:56:01Z

Run npm run burnthemall and see if that solves it for you

On Tue, Oct 18, 2016 at 7:53 PM, fredhampton notifications@github.com
wrote:

I tried the master build and it seems that iTunes images are not showing
Have the changes been pushed to master ?
Do I need to make any changes ?

Thanks !!

On October 18, 2016 at 12:27:30 PM, Paul Frazee (notifications@github.com)
wrote:

@fredhampton this is finally solved in master. Thank for being patient.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#94 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABNhU85LSBzlQOKkWjSmyZ5bgBCn1fR_ks5q1WoIgaJpZM4J71kJ
.

freedomtrain · 2016-10-19T14:27:13Z

After running npm run burnthemall I still have the issue
When I go here the thumb nails do not show
https://itunes.apple.com/us/artist/nina-simone/id79798

On October 18, 2016 at 7:56:07 PM, Paul Frazee (notifications@github.com) wrote:

Run npm run burnthemall and see if that solves it for you

On Tue, Oct 18, 2016 at 7:53 PM, fredhampton notifications@github.com
wrote:

I tried the master build and it seems that iTunes images are not showing
Have the changes been pushed to master ?
Do I need to make any changes ?

Thanks !!

On October 18, 2016 at 12:27:30 PM, Paul Frazee (notifications@github.com)
wrote:

@fredhampton this is finally solved in master. Thank for being patient.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#94 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABNhU85LSBzlQOKkWjSmyZ5bgBCn1fR_ks5q1WoIgaJpZM4J71kJ
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

pfrazee · 2016-10-19T15:27:28Z

Oh weird, it's suddenly not working for me either. Looking into it

pfrazee · 2016-10-19T16:32:18Z

I'm getting inconsistent behavior, that I can't find the pattern for. I did rm node_modules/electron and then npm i, and that solved it. Not sure what's going on.

Try this:

npm cache clean
npm run burnthemall

freedomtrain · 2016-10-19T16:34:02Z

I will give that a try

On October 19, 2016 at 9:32:22 AM, Paul Frazee (notifications@github.com) wrote:

I'm getting inconsistent behavior, that I can't find the pattern for. I did rm node_modules/electron and then npm i, and that solved it. Not sure what's going on.

Try this:

npm cache clean
npm run burnthemall
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

pfrazee · 2016-10-19T17:28:21Z

@fredhampton don't try that yet, I don't think it'll work. Something is wrong with my deployment process. I'll keep working and get back to you

freedomtrain · 2016-10-19T17:33:27Z

Ok
Thanks !

On October 19, 2016 at 10:28:27 AM, Paul Frazee (notifications@github.com) wrote:

@fredhampton don't try that yet, I don't think it'll work. Something is wrong with my deployment process. I'll keep working and get back to you

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

pfrazee · 2016-10-20T00:11:11Z

Ok try this again for me. Do this:

cd $your_electron_folder
git pull
npm cache clean
rm -Rf node_modules/electron
npm install
npm run build
npm start

Then open up one of these pages and LMK if you see the pics.

Thanks!

freedomtrain · 2016-10-20T00:39:16Z

I did all of the steps still no pics…..is there a way to clear the cache from beaker ….could this be the issue ?

On October 19, 2016 at 5:11:18 PM, Paul Frazee (notifications@github.com) wrote:

Ok try this again for me. Do this:

cd $your_electron_folder
git pull
npm cache clean
rm -Rf node_modules/electron
npm install
npm run build
npm start
Then open up one of these pages and LMK if you see the pics.

Thanks!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

pfrazee · 2016-10-20T01:21:31Z

No it has to do with a which version of electron is used. Let's see if this will be solved by my packaged release.

Sent from my iPhone

On Oct 19, 2016, at 7:39 PM, fredhampton notifications@github.com wrote:

I did all of the steps still no pics…..is there a way to clear the cache from beaker ….could this be the issue ?

On October 19, 2016 at 5:11:18 PM, Paul Frazee (notifications@github.com) wrote:

Ok try this again for me. Do this:

cd $your_electron_folder
git pull
npm cache clean
rm -Rf node_modules/electron
npm install
npm run build
npm start
Then open up one of these pages and LMK if you see the pics.

Thanks!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.

pfrazee · 2016-10-21T19:49:26Z

@fredhampton I found it. Turns out the electron binary is being cached in ~/.electron. Do the following for me:

cd $your_electron_folder
git pull
rm -Rf node_modules/electron
rm -Rf ~/.electron
npm install
npm run build
npm start

This should solve your other open issue.

freedomtrain · 2016-10-25T18:51:35Z

it WORKED !

Thanks so much !!!

On October 21, 2016 at 12:50:02 PM, Paul Frazee (notifications@github.com) wrote:

@fredhampton I found it. Turns out the electron binary is being cached in ~/.electron. Do the following for me:

cd $your_electron_folder
git pull
rm -Rf node_modules/electron
rm -Rf ~/.electron
npm install
npm run build
npm start
This should solve your other open issue.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

pfrazee · 2016-10-25T18:59:31Z

Great!

On Tue, Oct 25, 2016 at 1:51 PM, fredhampton notifications@github.com
wrote:

it WORKED !

Thanks so much !!!

On October 21, 2016 at 12:50:02 PM, Paul Frazee (notifications@github.com)
wrote:

@fredhampton I found it. Turns out the electron binary is being cached in
~/.electron. Do the following for me:

cd $your_electron_folder
git pull
rm -Rf node_modules/electron
rm -Rf ~/.electron
npm install
npm run build
npm start
This should solve your other open issue.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#94 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABNhU7ZWpdYRgx0ZjiefPFgekPT3fSbXks5q3k-5gaJpZM4J71kJ
.

pfrazee changed the title ~~images not showing on itunes page~~ HTTP images do not show on an HTTPS site Sep 13, 2016

pfrazee added bug discussion labels Sep 13, 2016

pfrazee changed the title ~~HTTP images do not show on an HTTPS site~~ Allow HTTP images to show on an HTTPS site Sep 13, 2016

pfrazee added enhancement Change that's on the roadmap electron and removed bug discussion labels Sep 13, 2016

pfrazee modified the milestone: 0.3.6 Sep 30, 2016

pfrazee mentioned this issue Oct 18, 2016

Custom Electron Build (which introduces fix for #94) #147

Merged

pfrazee closed this as completed in f1710d7 Oct 18, 2016

pfrazee added a commit that referenced this issue Oct 18, 2016

Merge pull request #147 from beakerbrowser/custom-electron-build

08766ad

Custom Electron Build (which introduces fix for #94)

pfrazee mentioned this issue Oct 24, 2016

Receiving error during load #151

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow HTTP images to show on an HTTPS site #94

Allow HTTP images to show on an HTTPS site #94

freedomtrain commented Sep 13, 2016

pfrazee commented Sep 13, 2016

freedomtrain commented Sep 13, 2016

pfrazee commented Sep 13, 2016

freedomtrain commented Sep 13, 2016

pfrazee commented Sep 13, 2016

freedomtrain commented Sep 16, 2016

pfrazee commented Sep 16, 2016

freedomtrain commented Sep 16, 2016

freedomtrain commented Sep 28, 2016

pfrazee commented Sep 28, 2016

freedomtrain commented Sep 28, 2016

pfrazee commented Oct 18, 2016

freedomtrain commented Oct 18, 2016

freedomtrain commented Oct 19, 2016

pfrazee commented Oct 19, 2016

freedomtrain commented Oct 19, 2016

pfrazee commented Oct 19, 2016

pfrazee commented Oct 19, 2016

freedomtrain commented Oct 19, 2016

pfrazee commented Oct 19, 2016

freedomtrain commented Oct 19, 2016

pfrazee commented Oct 20, 2016

freedomtrain commented Oct 20, 2016

pfrazee commented Oct 20, 2016

pfrazee commented Oct 21, 2016

freedomtrain commented Oct 25, 2016

pfrazee commented Oct 25, 2016

Allow HTTP images to show on an HTTPS site #94

Allow HTTP images to show on an HTTPS site #94

Comments

freedomtrain commented Sep 13, 2016

pfrazee commented Sep 13, 2016

freedomtrain commented Sep 13, 2016

pfrazee commented Sep 13, 2016

freedomtrain commented Sep 13, 2016

pfrazee commented Sep 13, 2016

freedomtrain commented Sep 16, 2016

pfrazee commented Sep 16, 2016

freedomtrain commented Sep 16, 2016

freedomtrain commented Sep 28, 2016

pfrazee commented Sep 28, 2016

freedomtrain commented Sep 28, 2016

pfrazee commented Oct 18, 2016

freedomtrain commented Oct 18, 2016

freedomtrain commented Oct 19, 2016

pfrazee commented Oct 19, 2016

freedomtrain commented Oct 19, 2016

pfrazee commented Oct 19, 2016

pfrazee commented Oct 19, 2016

freedomtrain commented Oct 19, 2016

pfrazee commented Oct 19, 2016

freedomtrain commented Oct 19, 2016

pfrazee commented Oct 20, 2016

freedomtrain commented Oct 20, 2016

pfrazee commented Oct 20, 2016

pfrazee commented Oct 21, 2016

freedomtrain commented Oct 25, 2016

pfrazee commented Oct 25, 2016