Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow sending custom args through SendGrid adapter #331

Closed
coryt opened this issue Nov 14, 2017 · 2 comments
Closed

Allow sending custom args through SendGrid adapter #331

coryt opened this issue Nov 14, 2017 · 2 comments
Labels
waiting-for-info Request for more information sent, awaiting reply

Comments

@coryt
Copy link
Contributor

coryt commented Nov 14, 2017

It looks like there is no way to send custom args through to SendGrid.

I would like to add support for this and it looks like it could be done by using the private map and exposing a function within the SendGridHelper to add custom args...

Thoughts?
@coryt coryt mentioned this issue Nov 14, 2017
Closed
@coryt coryt changed the title Cannot send custom args through SendGrid adapter Allow sending custom args through SendGrid adapter Nov 14, 2017
@coryt coryt mentioned this issue Nov 16, 2017
Closed
@lancejjohnson
Copy link
Contributor

@coryt If this is still an interest, please open a pull request with your recommended changes. Thanks!

@lancejjohnson lancejjohnson added the waiting-for-info Request for more information sent, awaiting reply label Apr 2, 2019
@germsvel
Copy link
Collaborator

Closing this issue (like we closed the associated PR #332) because it seems like #413 might be sufficient for sending custom args. If this should be reopened, please let me know. I'd be happy to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
waiting-for-info Request for more information sent, awaiting reply
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@coryt @lancejjohnson @germsvel