Possible send custom args in SendGridAdapter #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clairton
force-pushed
the
master
branch
2 times, most recently
from
3881f27
to
25f5b01
Compare
|
Could you please provide some test coverage that utilize the code committed? My last pr was to fix a bug most likely due to someone adding code that was not covered by the tests. |
|
ci is failing on apt update on OS yet. |
|
ping =) |
|
I'm re-running the specs now that Circle has been updated. Once it passes, I'll merge this in! |
|
It works! 👍 |
|
Woo hoo! |
|
This looks great 😄 Any idea when it's going to get released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.